Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore eslint --fix formatting changes in git blame #2287

Merged
merged 2 commits into from
Apr 9, 2022

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Apr 8, 2022

Ignore eslint --fix formatting changes in git blame

Docs: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

Dev notes

git log --all --grep='eslint'

This change is marked as an internal change (Task), so will not be included in the changelog.

@MadLittleMods MadLittleMods requested a review from a team as a code owner April 8, 2022 20:52
@MadLittleMods MadLittleMods added the T-Task Tasks for the team like planning label Apr 8, 2022
# eslint --fix
7ed65407e6cdf292ce3cf659310c68d19dcd52b2
# Switch to ESLint from JSHint (Google eslint rules as a base)
e057956ede9ad1a931ff8050c411aca7907e0394
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all of the entries for git log --all --grep='eslint' and added anything which was making formatting changes.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the commits, but hopefully it's fine.

@turt2live turt2live merged commit c6c22e3 into develop Apr 9, 2022
@turt2live turt2live deleted the madlittlemods/ignore-eslint-in-git-blame branch April 9, 2022 05:52
@MadLittleMods
Copy link
Contributor Author

Awesome! Just tried out the blame it led me straight to the commit instead of 4 different layers of cruft.

Thanks for the review and merge @turt2live 🦏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants