Attempt to fix megolm key not being in SSSS #1776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the account has both a key backup and SSSS enabled but the key backup key isn't stored in SSSS, try to save it there by getting it from either the cache or the user (if perhaps it's the same as their security passphrase but lost a passthrough entry). Fixes element-hq/element-web#17886
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jul 8, 2021
The device listener checks for a megolm key stored in SSSS but didn't update when one was added, so the encryption upgrade toast would not disappear after the key was fixed by matrix-org/matrix-js-sdk#1776
Mostly because that's what the test tests, so let's keep that behaviour the same.
jryans
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the account has both a key backup and SSSS enabled but the key
backup key isn't stored in SSSS, try to save it there by getting
it from either the cache or the user (if perhaps it's the same as
their security passphrase but lost a passthrough entry).
Fixes element-hq/element-web#17886