Convert SearchResult, InteractiveAuth, PushProcessor and Scheduler to TS #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chguy/ts/12 � Conflicts: � src/client.ts � src/interactive-auth.ts � src/models/search-result.ts
Contributor
|
This change is marked as an internal change (Task), so will not be included in the changelog. |
Member
Author
|
Blocked until after RC |
turt2live
requested changes
Aug 11, 2021
Member
|
gah, pressed buttons too quickly: overall the first readthrough of the diff looks fine. It's large enough where there's probably going to be a second read on re-review and a small chance of a third. |
Member
Author
|
@turt2live please merge after approval along with matrix-org/matrix-react-sdk#6323 - I will be on holiday |
turt2live
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.