Change call event handlers to adapt to undecrypted events #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
force-pushed
the
gsouquet/fix-call-handlers
branch
from
6d15719
to
32197ea
Compare
t3chguy
reviewed
May 19, 2021
|
Fixes #17393 |
dbkr
reviewed
May 19, 2021
|
I suppose this should be sent to release, right? |
Yes, I'll work on that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#17393
Regressed by #1684
The call event handler was expecting all messages to be decrypted or in the process of being decrypted and would not process any call events until everything has been processed.
The fix is to ignore all historical data by setting the listeners only after initial client sync