Support MSC3086 asserted identity #1674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can mock it out it tests (and also I'm not sure why it was like this in the first place: we passed the client in anyway...) Deprecate createNewMatrixCall
jryans
approved these changes
Apr 27, 2021
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Thanks, great to have tests for this new work! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for receiving MSC3086 Asserted Identity events & emitting event from the call object.
Also moves the method for creating new calls to the client so it can be stubbed out when testing applications using the js-sdk (the client was passed in before so I'm not sure what the benefit was of it being separate).