Delay otk generation #260
Merged
Delay otk generation #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And delay the upload of one-time keys until we have received a sync without any to-device messages. Equivalent to matrix-org/matrix-js-sdk#376
Make sure we upload one-time keys before doing the annoucement. Thus, other devices can download them once they receive our to-device annoucement event
Tests: Increase a bit test on time because the new flow seems slower.
ylecollen
approved these changes
Mar 7, 2017
Call [deviceList refreshOutdatedDeviceLists] after making announcement.
Call [deviceList refreshOutdatedDeviceLists] after making announcement. -> Do it on the right thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent of matrix-org/matrix-js-sdk#376.
With some differences / improvements due to the ios sdk behaviour: