Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Crypto SDK #1767

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Update Crypto SDK #1767

merged 1 commit into from
Apr 13, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Apr 13, 2023

Resolves element-hq/element-ios#7496

Latest version containing some deserialization bugfixes

@Anderas Anderas force-pushed the andy/crypto_version branch from b50a107 to f1c172f Compare April 13, 2023 09:32
@Anderas Anderas requested review from a team and pixlwave and removed request for a team April 13, 2023 09:32
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (5e21f59) 37.96% compared to head (f1c172f) 37.98%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1767      +/-   ##
===========================================
+ Coverage    37.96%   37.98%   +0.02%     
===========================================
  Files          616      616              
  Lines        97270    97270              
  Branches     42000    42001       +1     
===========================================
+ Hits         36928    36949      +21     
+ Misses       59295    59274      -21     
  Partials      1047     1047              

see 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anderas Anderas merged commit 10afb1b into develop Apr 13, 2023
@Anderas Anderas deleted the andy/crypto_version branch April 13, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CryptoStore error: invalid type: newtype struct, expected any valid JSON value
2 participants