Unread rooms: Move the storage file to a better location #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuroe
force-pushed
the
manu/fix_unread_file_location
branch
from
fc75558 to
aee67fc
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1730 +/- ##
===========================================
+ Coverage 37.53% 37.54% +0.01%
===========================================
Files 612 612
Lines 96235 96266 +31
Branches 41603 41618 +15
===========================================
+ Hits 36119 36142 +23
- Misses 59041 59071 +30
+ Partials 1075 1053 -22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It was previously stored alongside rooms: ``` ├── rooms │ ├── !TDpKIKrKaCXyncpKsH:localhost:8480 │ │ ├── messages │ │ ├── state │ │ └── threadedReadReceipts │ └── unreadRooms ``` This created an unexpected behavior because the method `MXFileStore.countOfRooms()` is based on number of items in the `rooms` folder. The result was the app recomputing room summaries on each startup if there were unread rooms: https://github.com/matrix-org/matrix-ios-sdk/blob/v0.25.2/MatrixSDK/MXSession.m#L470 The file is not at an upper level.
manuroe
force-pushed
the
manu/fix_unread_file_location
branch
from
aee67fc to
9b62e51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously stored alongside rooms:
This created an unexpected behavior because the method
MXFileStore.countOfRooms()is based on number of items in theroomsfolder. The result was the app recomputing room summaries on each startup if there were unread rooms: https://github.com/matrix-org/matrix-ios-sdk/blob/v0.25.2/MatrixSDK/MXSession.m#L470The file is not at an upper level.