Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete empty account_data events (PSG-688) #1656

Merged
merged 7 commits into from
Dec 14, 2022
Merged

Delete empty account_data events (PSG-688) #1656

merged 7 commits into from
Dec 14, 2022

Conversation

alfogrillo
Copy link
Contributor

Description

This PR removes empty account_data events in the sync.
They are coming back after someone calls DELETE on an account_data as described here.

Dependency

#1651

@alfogrillo alfogrillo changed the title Delete empty account_data events Delete empty account_data events (PSG-688) Dec 12, 2022
@alfogrillo alfogrillo requested a review from Anderas December 12, 2022 15:13
Base automatically changed from alfogrillo/delete_account_data to develop December 13, 2022 13:11
Anderas
Anderas approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@Anderas Anderas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to add some tests for this change, given it is a "destructive" operation.

@alfogrillo alfogrillo merged commit 22e4a73 into develop Dec 14, 2022
@alfogrillo alfogrillo deleted the alfogrillo/sync_account_data branch December 14, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anderas Anderas Anderas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfogrillo @Anderas