Add more logs when encrypting messages #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team,
pixlwave and
BillCarsonFr
and removed request for
a team
pixlwave
approved these changes
May 25, 2022
BillCarsonFr
approved these changes
May 31, 2022
Yes we log sending of the message in the HTTP client, which includes the room id as well as temporary local id. Once the message is sent, we log the transformation of the local id into permament id. The logs are a bit scattered around amid other stuff but all the info is there. Adding one more roomId at the start to make this easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/matrix-org/element-ios-rageshakes/issues/18461
There are rare reports of rooms forgetting that they are encrypted, and it is plausable that this is caused by some state corruption. Given some existing measures that restore summary encryption if crypto store contains an algorithm, this state loss would need to be more comprehensive. Either way there isn't currently enough logs to pinpoint more precisely why encryption is not possible. This PR merely adds a few more logs to the encryption flow.