Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "accounts" command (always return undefined [Protocol not enabled]) #44

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Ghabry
Copy link

@Ghabry Ghabry commented Feb 8, 2019

Changed from protocolId to protocol_id which matches the key in the db file

@Half-Shot
Copy link
Collaborator

Don't know how I even missed this for a month :(.

@Half-Shot
Copy link
Collaborator

@Ghabry Could you direct the PR towards develop and also sign off your PR as seen in https://github.com/matrix-org/matrix-doc/blob/master/CONTRIBUTING.rst

@Neustradamus
Copy link

@Ghabry: Any news?

Changed from protocolId to protocol_id which matches the key in the db file

Signed-off-by: Ghabry <gabriel+github@mastergk.de>
@Ghabry Ghabry changed the base branch from master to develop August 16, 2020 18:28
@Ghabry
Copy link
Author

Ghabry commented Aug 16, 2020

@Half-Shot

Sorry for not responding :(((

The target branch is now "develop", I rebased and added a "Sign off" message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants