update CONTRIBUTING.md with DCO #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
reviewed
Jul 24, 2024
| @@ -125,6 +125,59 @@ When reviewing a PR, a maintainer will: | |||
| they have acknowledged the message and will make the change. | |||
| - Approve a PR which is ready to merge, or nearly ready with some minor tweaks or optional improvements. | |||
|
|
|||
| ### Sign off | |||
There was a problem hiding this comment.
N.B. just to mention that we link to the Synapse sign off page above. You might wanna adjust that link. https://github.com/matrix-org/matrix-appservice-bridge/pull/502/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055R94
There was a problem hiding this comment.
Oh yes good catch, this is as good a time as any to update that link. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Matrix.org Foundation is rolling out this DCO across all public repositories in its namespace. Of note, this DCO does not require the use of "real" or "legally identifiable" names.