-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for media proxying (for MSC3910) #444
Conversation
Addressed this one in #498 with a tightly packed data format – brings |
https://github.com/tadzik/matrix-appservice-bridge/tree/tadzik/media-proxy brings this up to Few things still worth figuring out:
|
Saves us 80 bytes for the test data (down from 208 to 128), while leaving room for future changes.
MSC3910 will introduce the requirement to authenticate media downloads, which will leave bridges like matrix-appservice-irc, which presently rely on unauthenticated media to function.
To combat this, this PR introduces a transparent proxy service that will allow unauthenticated media access to continue, albeit with more control over the scope and lifetime of the media. This is done by creating and signing some metadata, that is then provided as a URL for the media. This avoids the need for unbounded storage of media records in the bridge.
Problems: