Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PostgresStore abstraction #442

Merged
merged 6 commits into from
Nov 16, 2022
Merged

Add PostgresStore abstraction #442

merged 6 commits into from
Nov 16, 2022

Conversation

Half-Shot
Copy link
Contributor

This semi-ports the IRC bridge implementation of a Postgres Datastore to this library. There are some key differences though:

  • It's a very cut back abstract class that only deals with schema updates, for now.
  • It deliberately doesn't try to implement any of our datastore classes for the moment, leaving that exercise to the bridge developer.
  • We use the https://www.npmjs.com/package/postgres library, which has a (IMO) nicer syntax and natural support for TypeScript.
  • Schema updates are now more typesafe than before.

@Half-Shot Half-Shot requested a review from a team as a code owner October 6, 2022 09:43
@Half-Shot Half-Shot mentioned this pull request Oct 6, 2022
Open
@Half-Shot Half-Shot self-assigned this Oct 18, 2022
This was referenced Nov 8, 2022
Merged
Open
AndrewFerr
AndrewFerr requested changes Nov 9, 2022
View reviewed changes
spec/helpers/postgres-helper.ts Outdated Show resolved Hide resolved
spec/helpers/postgres-helper.ts Show resolved Hide resolved
spec/integ/postgres.spec.ts Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
src/components/stores/postgres-store.ts Show resolved Hide resolved
src/components/stores/postgres-store.ts Outdated Show resolved Hide resolved
src/components/stores/postgres-store.ts Outdated Show resolved Hide resolved
src/components/stores/postgres-store.ts Show resolved Hide resolved
src/components/stores/postgres-store.ts Outdated Show resolved Hide resolved
spec/integ/postgres.spec.ts Show resolved Hide resolved
@Half-Shot Half-Shot merged commit f2f2917 into develop Nov 16, 2022
@Half-Shot Half-Shot deleted the hs/postgres-store branch May 2, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees

@Half-Shot Half-Shot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @AndrewFerr