Add support for ephemeral events from the AS API #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
reviewed
Oct 8, 2020
| return undefined; | ||
| }); | ||
| this.appservice.on("ephemeral", async (event) => | ||
| this.onEphemeralEvent(event as unknown as EphemeralEvent) |
Contributor
There was a problem hiding this comment.
Is this really guaranteed to be an EphemeralEvent or is as unknown as X the new any?
Contributor
Author
There was a problem hiding this comment.
It's guaranteed. matrix-appservice-node doesn't have types and will send us a Record<string, unknown> but that doesn't cast to a EphemeralEvent easily. The homeserver will only send us these events however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-appservice-node#32, matrix-org/synapse#8437
Most of the interesting things are in those two PRs, but this means we can handle ephemeral data from the AS api rather than just /sync.