Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interaction events for the activity toggles #101

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Apr 12, 2024

No description provided.

@dbkr dbkr requested a review from a team as a code owner April 12, 2024 13:15
@dbkr dbkr requested a review from bmarty April 12, 2024 13:15
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this pull request Apr 12, 2024
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dbkr dbkr merged commit 5bf24eb into main Apr 22, 2024
3 checks passed
@dbkr dbkr deleted the dbkr/activity_toggles_analytics branch April 22, 2024 12:32
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this pull request Apr 22, 2024
* Add analytics to activity toggles

Requires matrix-org/matrix-analytics-events#101

* Add test

* Fix comment a bit

* Update to new analytics events package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants