Add support for getting authenticated federation media #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenrikSolver
left a comment
HenrikSolver
left a comment
There was a problem hiding this comment.
To my understanding this looks fine.
| } | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
I think documentation in the same spirit as the other methods would be appropriate.
Collaborator
Author
There was a problem hiding this comment.
Fair, and good to document that the caller of this method is responsible to close the returned response body, if any.
Collaborator
Author
|
Thanks for the review! :) |
S7evinK
added a commit
to matrix-org/dendrite
that referenced
this pull request
Aug 16, 2024
neilalexander
pushed a commit
to neilalexander/harmony
that referenced
this pull request
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.