All might legend/issue1963 #3409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key Features: Password Configuration: The PasswordConfig struct allows customization of the password validation requirements. This can be extended to include more complex policies as needed. YAML Configuration: The PasswordConfig struct could be loaded from a YAML file, enabling dynamic adjustment of the password requirements without code changes. Password Validation: The ValidatePassword function checks the length, presence of uppercase letters, lowercase letters, digits, and special characters based on the provided configuration. Sidecar Feature: A placeholder sidecarLogPasswordValidation function is included, where you could integrate with a logging service to track password validation attempts. Signed-off-by: AllMightLegend srinjoysen123@gmail.com
|
I am new to open source contribution. I have tried to contribute to matrix-spec previously and due to mistakes I have been given some healthy tips. I have tried to incorporate those tips. Would be happy for more advice so that I can learn more. |
|
Sorry for closing this, feel free to join #dendrite-dev:matrix.org for further discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Signed-off-by:
Srinjoy Sen Chowdhury srinjoysen123@gmail.comFixes issue#1963
Key Features:
Password Configuration:
The PasswordConfig struct allows customization of the password validation requirements. This can be extended to include more complex policies as needed.
YAML Configuration:
The PasswordConfig struct could be loaded from a YAML file, enabling dynamic adjustment of the password requirements without code changes.
Password Validation:
The ValidatePassword function checks the length, presence of uppercase letters, lowercase letters, digits, and special characters based on the provided configuration.
Sidecar Feature:
A placeholder sidecarLogPasswordValidation function is included, where you could integrate with a logging service to track password validation attempts.
Usage Example:
In a real-world scenario, you would load PasswordConfig from a YAML file or another configuration source and pass it to ValidatePassword when validating user passwords.
This structure makes it easier to manage and enforce password policies while providing flexibility for future changes.