This repository was archived by the owner on Nov 25, 2024. It is now read-only.
Change Default Room version to 10 #2933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S7evinK
added
the
T-Enhancement
Codecov ReportBase: 37.97% // Head: 37.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2933 +/- ##
==========================================
- Coverage 37.97% 37.90% -0.08%
==========================================
Files 496 496
Lines 54964 54964
==========================================
- Hits 20875 20832 -43
- Misses 31527 31557 +30
- Partials 2562 2575 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Member
I ended up doing this on develop in matrix-org/sytest#1328. |
Contributor
|
Thanks for this! |
S7evinK
approved these changes
Jan 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements MSC3904. This PR is almost identical to #2781 but this PR is also filed well technically 1 day before the MSC passes FCP but well everyone knows this MSC is expected to have passed FCP on monday so im refiling this change today on saturday as i was doing prep work for monday. I assume that this PR wont be counted as clogging the queue since by the next time i expect to be a work day for this project this PR will be implementing an FCP passed disposition merge MSC.
Also as for the lack of tests i belive that this simple change does not need to pass new tests due to that these tests are expected to already have been passed by the successful use of Dendrite with Room version 10 already.
Pull Request Checklist
Signed-off-by: Catalan Lover catalanlover@protonmail.com