This repository was archived by the owner on Nov 25, 2024. It is now read-only.
Fix: Appservice not getting invite events from remote server #2476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekgonecrazy
force-pushed
the
fix/room-invite
branch
from
863c675 to
0d8a0a2
Compare
Signed-off-by: Aaron Ogle <aaron@geekgonecrazy.com>
geekgonecrazy
force-pushed
the
fix/room-invite
branch
from
0d8a0a2 to
4080303
Compare
kegsay
approved these changes
May 24, 2022
Member
kegsay
left a comment
kegsay
left a comment
There was a problem hiding this comment.
Thanks for this! At present there are no component tests for the appservice api unfortunately. I'm slowly revisiting old code and adding tests in, but haven't got to this one yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes #2475
Previously if not a roomevent it was ignored by the roomevent consumer. Seems like most events we care about are room events. But invite is also important for the appservice to know about. Also works with Synapse.. so Dendrite needs to handle it as well.
Not sure if this is the best place. I haven't spent much time in the code base yet to be sure
Regarding tests.. Unless i'm missing something it seems the appserver portion isn't covered by tests
Signed-off-by:
Aaron Ogle <aaron@geekgonecrazy.com>