Fix TestAsyncUpload tests not being independent#838
Merged
MadLittleMods merged 5 commits intomainfrom Jan 26, 2026
Merged
Conversation
MadLittleMods
commented
Jan 22, 2026
Comment on lines
+77
to
+82
| // TODO: This is the same as the test below (both use authenticated media). Previously | ||
| // this was testing unauthenticated vs authenticated media. We should resolve this by | ||
| // removing one of these tests or ideally, keeping both authenticated and | ||
| // unauthenticated tests and just gate it behind some homeserver check for | ||
| // unauthenticated media support (see | ||
| // https://github.com/matrix-org/complement/pull/746#discussion_r2718904066) |
Collaborator
Author
There was a problem hiding this comment.
This is a future TODO (something to do in another PR).
See #746 (comment)
devonh
approved these changes
Jan 26, 2026
Contributor
devonh
left a comment
devonh
left a comment
There was a problem hiding this comment.
Nice improvement to split out the interdependencies.
MadLittleMods
deleted the
madlittlemods/fix-media-async-upload-tests-not-being-independent
branch
Collaborator
Author
|
Thanks for the review @devonh 🦧 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
TestAsyncUploadtests not being independent. Previously, they relied on being run sequentially.Now you can run tests individually:
This refactor is spawning from #839 where I wanted to specifically run the flaky test.
Dev notes
TestAsyncUploadoriginally introduced in #641How to run in
element-hq/synapse-rust-apps:Pull Request Checklist