-
Notifications
You must be signed in to change notification settings - Fork 60
Add tests for downgrading a v12 room to one that doesn't support MSC4289 #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It was unused, and had a bug in it ('addition_users' should go under 'creation_content').
|
They also proposed just setting the creator's power level to In addition, this would be much easier for homeservers to implement (and thus not introduce bugs) than taking the max of a bunch of different fields. |
| LocalpartSuffix: "charlie", | ||
| }) | ||
|
|
||
| testCases := []struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed from review queue "while the exact power level is worked out."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now tracked at matrix-org/matrix-spec#2253
…_downgrading_v12_rooms
* Creators in the new room should have the max canonicaljson int * If a non-creator in the v12 room had max canonicaljson int already, demote them by 1
Adds some tests for downgrading a v12 room. Also cleans up some existing tests and fixes a typo.
additional_creators) to in the new room when downgrading to a room that does not support MSC4289.The general consensus seems to be setting their power level(s) to the minimum needed to send
m.room.power_levelsin the room - aka being able to do anything you want in the room. Synapse implements this as taking the max of all fields underevents, andstate_default(which would apply tom.room.power_levelsif it wasn't listed underevents).This PR would effectively be requiring the above of homeservers without the spec having yet agreed on it yet. We should hold off on merging this PR until that is decided.
Recommended to review commit-by-commit.