Fix being able to re-use request path parts in MustDo/Do

[MadLittleMods]

Fix being able to re-use request path parts in MustDo/Do

Previously, this example wouldn't work:

alice := deployment.Register(t, "hs1", helpers.RegistrationOpts{})
roomID := alice.MustCreateRoom(t, map[string]interface{}{
	"preset": "public_chat",
})

requestPathParts := []string{"_matrix", "client", "v3", "directory", "list", "room", roomID}
alice.MustDo(t, "GET", requestPathParts)
// 404 because the path is already escaped and will be escaped again
alice.MustDo(t, "GET", requestPathParts)

    client.go:685: [CSAPI] GET hs1/_matrix/client/v3/directory/list/room/!DolNGvQqgiKnDmimTj:hs1 => 200 OK (3.324405ms)
    client.go:685: [CSAPI] GET hs1/_matrix/client/v3/directory/list/room/%21DolNGvQqgiKnDmimTj:hs1 => 404 Not Found (3.030919ms)

Pull Request Checklist

• Pull request includes a sign off

Signed-off-by: Eric Eastwood erice@element.io

[anoadragon453]

Common footgun when passing by reference. Thanks for fixing!

[anoadragon453]

I'm not sure why the sign-off is failing, considering it does check the raw markdown PR body, and the regex will match what you've wrote.

Merging anyways.

[MadLittleMods]

Thanks for the review and merge @anoadragon453 🦑