Add COMPLEMENT_ENABLE_DIRTY_RUNS to vastly speed up test runs #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kegsay
changed the title
kegsay
force-pushed
the
kegan/enable-dirty-runs
branch
from
3c7136d
to
c946bc7
Compare
DMRobertson
reviewed
Oct 18, 2023
Comment on lines
+45
to
+46
| // Use a clean deployment for these tests so the user directory isn't polluted. | ||
| deployment := complement.OldDeploy(t, b.BlueprintCleanHS) |
DMRobertson
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This halves the runtime of Synapse tests on SQLite. This will likely be an even bigger improvement on postgres/workers due to the setup time there being even longer.