Fix flakey 'query remote device keys' test #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
reviewed
Sep 4, 2023
Comment on lines
+83
to
+85
| // Device list changes only come down incremental syncs, so we do an | ||
| // initial sync up front. | ||
| _, nextBatch := bob.MustSync(t, client.SyncReq{}) |
There was a problem hiding this comment.
This seems reasonable---but how did the test ever pass without this?
There was a problem hiding this comment.
I think that things were slow enough that the device list update wouldn't make it down the first /sync?
DMRobertson
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e.
TestFederationKeyUploadQuery/Can_query_remote_device_keys_using_POST/Can query remote device keys using POSTCloses matrix-org/synapse#16020