Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sytest: Add 31sync/09archived tests #534

Merged
merged 5 commits into from
Nov 3, 2022

Conversation

ShadowJonathan
Copy link
Contributor

@ShadowJonathan ShadowJonathan commented Oct 21, 2022

This adds 8 sytests:

  • ./tests/31sync/09archived.pl:test "Archived rooms only contain history from before the user left",
  • ./tests/31sync/09archived.pl:test "Left rooms appear in the leave section of full state sync",
  • ./tests/31sync/09archived.pl:test "Left rooms appear in the leave section of sync",
  • ./tests/31sync/09archived.pl:test "Newly left rooms appear in the leave section of gapped sync",
  • ./tests/31sync/09archived.pl:test "Newly left rooms appear in the leave section of incremental sync",
  • ./tests/31sync/09archived.pl:test "Previously left rooms don't appear in the leave section of sync",
  • ./tests/31sync/09archived.pl:test "We should see our own leave event when rejecting an invite, ".
  • ./tests/31sync/09archived.pl:test "We should see our own leave event, even if history_visibility is " .

This also brushes up on an csapi-internal function createFilter, to have it create less boilerplate.

Tests are skipped on dendrite because of matrix-org/dendrite#1323

@ShadowJonathan ShadowJonathan requested review from a team as code owners October 21, 2022 18:04
# Conflicts:
#	tests/csapi/sync_filter_test.go
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks roughly equivalent to the original sytests.

Some minor nits.

tests/csapi/sync_archive_test.go Outdated Show resolved Hide resolved
tests/csapi/sync_archive_test.go Outdated Show resolved Hide resolved
tests/csapi/sync_archive_test.go Show resolved Hide resolved
tests/csapi/sync_archive_test.go Show resolved Hide resolved
tests/csapi/sync_archive_test.go Show resolved Hide resolved
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants