Allow specifying server_name parameter values when joining a room #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
serverName
argument toCSAPI.JoinRoom
, allowing clients to populate theserver_name
query parameter.Additionally useful for homeservers that don't parse server names from room IDs.
Fixes: #39
Aside: I didn't put any newlines between logical blocks of code as the rest of the codebase doesn't do this, even though I sort of wanted to. Is there a general code style for complement defined anywhere?