Conversation
- Added `runtime.SkipIf` - Re-combined federation test as it can now be individually skipped on Dendrite. From a CI perspective, no changes are required as this uses the existing build tags setup to detect HS impl.
neilalexander
approved these changes
Nov 22, 2021
Contributor
neilalexander
left a comment
neilalexander
left a comment
There was a problem hiding this comment.
Overall PR looks fine. Not sure if it is idiomatic to overload a standard library package name (runtime) but I don't suppose in this case it really matters given that the runtime packgae is really quite specialised.
Member
Author
|
That was my thinking: it's rare to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime.SkipIfFrom a CI perspective, no changes are required as this uses the existing build
tags setup to detect HS impl. Fixes #227