Test auth of events with rejected auth_events #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should make sure that events that refer to rejected events in their auth_events are themselves rejected. See matrix-org/synapse#9595.
richvdh
force-pushed
the
rav/handle_rejected_auth_events
branch
from
ae676b8 to
6691908
Compare
Member
Author
|
looks like dendrite has this bug too. I'm not sure how best to handle that: should I blacklist the test for dendrite somehow for now? |
DMRobertson
approved these changes
Oct 5, 2021
Co-authored-by: David Robertson <davidr@element.io>
DMRobertson
approved these changes
Oct 5, 2021
Also, link to synapse issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should make sure that events that refer to rejected events in their
auth_events are themselves rejected.
See matrix-org/synapse#9595, and the fixes at matrix-org/synapse#10956.