Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support testing Synapse with Postgres #323

Closed
babolivier opened this issue Feb 18, 2022 · 6 comments
Closed

Support testing Synapse with Postgres #323

babolivier opened this issue Feb 18, 2022 · 6 comments

Comments

@babolivier
Copy link
Contributor

matrix-org/synapse#12024 raised the issue that, since the images we use for Synapse only support SQLite, we might be missing some pretty bad bugs. In this specific case, Complement shows Synapse's implem as passing whereas it's actually broken for any instance using PostgreSQL (which should be most Synapse instances). It sounds to me like we could really benefit from having Dockerfiles and config files for Synapse that support Postgres.

@kegsay
Copy link
Member

kegsay commented Feb 18, 2022

@richvdh
Copy link
Member

richvdh commented Feb 18, 2022

This is really a subset of testing Synapse with worrkers (matrix-org/synapse#12638)

@babolivier
Copy link
Contributor Author

This is really a subset of testing Synapse with worrkers (matrix-org/synapse#12638)

Is it? Being able to test with PostgreSQL would have raised matrix-org/synapse#12024 even without workers support afaict.

@richvdh
Copy link
Member

richvdh commented Feb 21, 2022

It's a subset in that, if we test with workers, we will necessarily be testing with Postgres too. I'm not saying there wouldn't be advantages to testing with Postgres as a monolith too.

@babolivier
Copy link
Contributor Author

Ah right, gotcha, thanks for clarifying.

@DMRobertson
Copy link
Contributor

DMRobertson commented May 31, 2022

Redundant now that matrix-org/synapse#12638 is closed? (And arguably not a problem for the complement repo?)

@richvdh richvdh closed this as completed May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants