Control results directory #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Any comments on regarding this one? |
Collaborator
|
@dopplershift - looks good, but you could you add a test? |
Contributor
Author
|
Happy to. |
Contributor
Author
|
Ok, test added. |
Contributor
Author
|
Same odd failure with 2.x that I can't get locally. |
Collaborator
|
@dopplershift - I'm fixing it in #42. By the way, to reproduce the failure locally you'd likely need to run pytest with the |
Collaborator
|
@dopplershift - can you rebase on the latest master? (I've merged in changes that should fix Travis) |
This makes it easier to find them than looking for a random directory somewhere in /tmp (which is even weirder on osx).
Not only does this seem more fitting, but it permits suppressing the traceback; currently this traceback was only into the pytest-mpl plugin code, so it wasn't very useful at all for users.
dopplershift
force-pushed
the
output_dir
branch
from
20fd471 to
c1edb78
Compare
Contributor
Author
|
Travis failure on osx with python 2.6 looks spurious. |
Collaborator
|
@dopplershift - sorry for the delay, and thanks for the addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another command line option to specify where results should end up (before the random identifier). That way you can dump them to a location that's easy to get to when things fail.
I also changed
raise Exception(msg)to usingpytest.fail(msg, pytrace=False). The latter better reflects what happens, and withpytrace=Falseit suppresses the traceback, so users don't needlessly see a backtrace into the pytest-mpl plugin code.