Skip to content

Add doc hosting on readthedocs #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 10, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable gallery execution
  • Loading branch information
dstansby committed May 10, 2023
commit f88ec4a33166c4b4fffc0664cbdbcdc8137fcc38
4 changes: 3 additions & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
]

sphinx_gallery_conf = {
"filename_pattern": ".",
# Don't run any gallery examples, because they're not working on
# readthedocs at the moment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 But it was so nice.

What was the problem? I assume it's not a problem of xfvb on rtd?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but xvfb just kept crashing. Might be due to some leaking/non-closed widgets, but the error message wasn't helpful enough to make a more educated guess.

Copy link
Collaborator

@samcunliffe samcunliffe May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we would need sudo access to a headless 18.04 VM to try it ourselves?

"filename_pattern": "a^",
"image_scrapers": (qtgallery.qtscraper,),
"reset_modules": (qtgallery.reset_qapp,),
}
Expand Down