Make widget compliant with napari color scheme #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
May 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 89.69% 90.56% +0.87%
==========================================
Files 7 7
Lines 97 106 +9
==========================================
+ Hits 87 96 +9
Misses 10 10
Continue to review full report at Codecov.
|
dstansby
approved these changes
May 5, 2022
Member
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
Looks great, thanks a lot! I have some suggested improvements in mind, but I'll put those in a new issue since I don't want to block this improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Hi @dstansby ,
I made some changes to the style of the plot widget. Not really by introducing a style sheet (I'm not sure whether that concept applies to canvas/axes objects) but just by creating a ax instance with changed spine/tick/background parameters.
Let me know what you think :)