Skip to content

Conversation

@anbarief
Copy link
Contributor

there are two equal commands for each if-else block. So I just combined into one block.

there are two equal commands for each if-else block. So I just combined into one block.
@DanielGoldfarb
Copy link
Collaborator

I don't think this appreciably adds to the readibility. On the contrary the existing code makes it clear that there are two ways to accomplish the same thing, where one is a kwarg setting and the other is a default behavior.

Regarding efficiency, while this change may be ever so slightly more efficient, the amount is so small as to be virtually impossible to notice in any practical situation.

I am therefore going to close this without merging. @anbarief Areif, Thank you for your willingingness to contribute. It is very truly appreciated. I have merged your other PR just recently. Again, very much appreciated. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants