-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Removed financial demos that stalled because of yahoo requests #7057
Conversation
…hat never end (timeout way too long)
The examples are being build on travis (as late as 6 hours ago https://travis-ci.org/matplotlib/matplotlib/builds/158107836) so I think this is a temporary outage. I would suggest just disabling them from running as parts of the docs build as suggested in #7049 |
@jenshnielsen I think we should remove them:
|
|
It may be that the finance module is already deprecated but we can't remove it unless we want lots of complaints from users that are still depending on it. I am just suggesting that we:
|
I think the data used in the examples can be saved to mpl repository and used to 'proxify' urllib requests. It can also be used in the tests for financial module |
Oh sorry for closing. This was a mistake. |
Why not generate totally fake data instead, would this make a difference for the example ? |
I agree that it's not a good use of time to do any work on these examples to fix the data loading then I would rather delete them, I just suggest that they should be deleted when they are moved with the finance code to their own repository. Then if anyone should feel like improving the code and or the examples they can do so in that repository independent of matplotlib. |
There is |
I will try to get around to creating a mpl_finance package asap that way we can delete the examples right away and perhaps even the finace module in time for 2.0 |
We probably should shim out mpl.finance to import from the new package and raise an exception with instructions of what to install to fix it. |
To keep things moving for @NelleV and company I am going to merge this and then immediantly open a PR to revert the merge. I think this unblock current progress and make sure we do not (will make it less likely) that these fall through the cracks. |
Just waiting for the docs to finish on travis to make sure we do not have an explicit reference to any of these. |
There seems to be a hard-coded list someplace
|
Minimal mpl_finance package up at https://github.com/matplotlib/mpl_finance |
DOC: Removed financial demos that stalled because of yahoo requests
backported to v2.x as b152ff9 |
\o/ Thanks! |
This PR removes 5 examples from the documenation because they are relying on financial data from yahoo that do not seem to be available anymore. see #7049