Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_galata_references github action #545

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

ianthomas23
Copy link
Member

Here I am trying to fix the update_galata_references github action after the recent changes that broke it. It should be run as before by adding a PR comment containing the text "update galata references". I have checked in a couple of incorrect test images so that the update is required before CI will pass.

This is not yet using the JupyterLab maintainer-tools, that is something to consider in the future.

@ianthomas23
Copy link
Member Author

Please update galata references.

1 similar comment
@ianthomas23
Copy link
Member Author

Please update galata references.

@ianthomas23
Copy link
Member Author

Pretty please update galata references.

@ianthomas23
Copy link
Member Author

Hmm, it is running the action from the main branch not this PR branch, as it is running code that I have deleted in this branch.

@martinRenou
Copy link
Member

Yep the bot runs from the main branch. Last time I checked, it's not possible for it to run on the branch that originated the PR.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's merge and test it

@martinRenou martinRenou merged commit 1d304ac into matplotlib:main Jan 29, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants