Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build using JupyterLab 4 #543

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

ianthomas23
Copy link
Member

Closes #539.

This changes the build system to build against JupyterLab 4 rather than 3. I have manually checked that the wheel generated in this way works on all the following:

  • JupyterLab 4
  • JupyterLab 3
  • Notebook 7
  • Notebook 6
  • nbclassic

Note that ipympl already worked fine on JupyterLab 4, this just modernises the build process.

Copy link
Contributor

Binder 👈 Launch a binder notebook on branch ianthomas23/ipympl/build_using_jlab4

@ianthomas23
Copy link
Member Author

I've removed the captions above the Matplotlib figures otherwise slight differences in rendering between ubuntu and macos cause the image comparison tests to fail. These captions are in <div>s anyway rather than generated by Matplotlib.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@martinRenou martinRenou merged commit 3297599 into matplotlib:main Jan 26, 2024
9 checks passed
@ianthomas23 ianthomas23 deleted the build_using_jlab4 branch January 26, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please remove jupyterlab==3.* requirement so as to allow 4.x to work.
2 participants