Improve coverage #41
Merged
Improve coverage #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
force-pushed
the
improve_coverage
branch
from
4c16a5f to
87c8516
Compare
These were some of the edge cases handled in arranging the grids.
Rather than attempting to actually plot these grids and match against an image or an SVG, we can instead mock out GridStrategy and ensure that the correct arrangement of grids is returned.
Because all the calls in this test were expected to raise an error, after the first one, none of the others were even tried. This makes each failing call a separate test.
pganssle
force-pushed
the
improve_coverage
branch
from
87c8516 to
78ede19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest problem with the coverage was that we could not test
GridSpecobjects, so I have created a small mock that allows us to ensure the right grid specs are created.This brings the code coverage up to 98%. The only remaining untested lines are never hit by the "main" functions, and I am somewhat reluctant to directly test
stripe_evenandstripe_odd, because I'm not entirely sure why I made them public.