Skip to content

Conversation

@ossdev07
Copy link

@ossdev07 ossdev07 commented Dec 24, 2019

Added ARM64 jobs in Travis-CI

Signed-off-by: ossdev07 <ossdev@puresoftware.com>
@codecov-io
Copy link

codecov-io commented Dec 24, 2019

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #53   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         184    184           
  Branches       51     51           
=====================================
  Hits          184    184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dc2965...ef1141d. Read the comment docs.

@rhenwood-arm
Copy link

@ossdev07: I find it very difficult to quickly scan for 'arm64' and 'amd64' lines. Is there a better way to express testing these two platforms in travis-ci yaml?

@QuLogic
Copy link
Member

QuLogic commented Dec 30, 2019

Does Travis not do matrix expansion on arch? Also, there's no compiled code in cycler, so I'm not sure there's much benefit to testing on two arches.

@tacaswell
Copy link
Member

I suspect that @rhenwood-arm can provide some insight on if it is worth testing cycler on arm.

Given that it is pure-python I don't think we would be doing anything other than testing python-on-arm. On the other hand no one ever thinks they are doing something funny that is going to break on a different architecture so testing can't hurt.

@Kojoley
Copy link
Member

Kojoley commented Jan 4, 2020

Does Travis not do matrix expansion on arch?

Yes, it does. https://docs.travis-ci.com/user/multi-cpu-architectures/#testing-on-multiple-cpu-architectures

@rhenwood-arm
Copy link

https://github.com/matplotlib/matplotlib has had regressions on Arm and is a requirement of this project so that project is probably the most valuable place for CI for AArch64 today. @ossdev07 : I suggest at first you look into adding a Travis-CI job for Matplotlib - and use the matrix expansion to enhance readability.

@tacaswell
Copy link
Member

Did the ARM regressions on Matplotlib get reported to us? We have a fair amount of c++ code in Matplotlib so I would expect it to have more issues than cycler.

Definitely 👍 on getting an arm job on matplotlib/matplotlib, however we probably only want 1 or two (latest python only?) as our full test suite already takes a long time to run.

@Kojoley
Copy link
Member

Kojoley commented Jan 6, 2020

Numpy lacks wheels for arm64 and building it fails with a compiler crash https://travis-ci.org/Kojoley/matplotlib/jobs/633312381

@tacaswell
Copy link
Member

I'm going to close this because we no longer use travis for CI.

Given that this is a pure Python package, I do not expect there to be any arm related issues that come from this code so getting arm testing on cycler seems like a low priority.

@tacaswell tacaswell closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants