drawgreatcircle() now correctly returns a Line2D object #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeatherGod
requested changes
Oct 3, 2016
| p.vertices = verts | ||
|
|
||
| return p | ||
| return _p |
There was a problem hiding this comment.
Could you also tweek the docstring a bit so that it says that a list of one Line2D object is returned, much like a call to pyplot.plot() would return?
|
Sorry about the delay in responding... I actually replied on Friday, but I haven't gotten the hang of the new review system yet. |
WeatherGod
approved these changes
Oct 10, 2016
|
Thanks for your patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #322 for a problem description.
This minimally invasive change fixes it.