Skip to content

Fix markers table for display in JupyterLab - #29

Merged
timhoffm merged 2 commits into
matplotlib:masterfrom
JarnoRFB:fix-marker-table
Apr 23, 2019
Merged

timhoffm merged 2 commits into
matplotlib:masterfrom
JarnoRFB:fix-marker-table

Conversation

@JarnoRFB

Copy link
Copy Markdown
Contributor

Before the changes, the table was not rendered properly.

Before the changes, the table was not rendered properly.

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, I suspect that the dialect of markdown that is acceptable drifted a bit?

Comment thread AnatomyOfMatplotlib-Part3-HowToSpeakMPL.ipynb Outdated
@timhoffm

Copy link
Copy Markdown
Member

This is a known issue jupyterlab/jupyterlab#5007.

We "misused" empty cells to have a visual separation of the marker/description column pairs.

@timhoffm
timhoffm merged commit 0ff68e0 into matplotlib:master Apr 23, 2019
@timhoffm

Copy link
Copy Markdown
Member

@JarnoRFB Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants