Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements around validity checks for redirect urls #22474

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Improvements around validity checks for redirect urls #22474

merged 2 commits into from
Aug 5, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 5, 2024

Description:

Applies #22402 and #22412

Review

sgiehl added 2 commits August 5, 2024 15:44
@sgiehl
Improve URL check for logme redirect (#22402)
4045c95 
* Improve URL check for redirect

* adds regression test
@sgiehl
Improve validity check for redirect urls (#22412)
84631c6 
* Improve validity check for redirect urls

* Adds regression test
@sgiehl sgiehl added the c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. label Aug 5, 2024
@sgiehl sgiehl added this to the 5.1.1 milestone Aug 5, 2024
@sgiehl sgiehl requested a review from a team August 5, 2024 13:48
@mneudert mneudert merged commit d8b4b3b into 5.1.x-dev Aug 5, 2024
23 of 25 checks passed
@mneudert mneudert deleted the applyredirectfixes branch August 5, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github.
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @mneudert