-
Notifications
You must be signed in to change notification settings - Fork 14
Merge v2-beta changes to main #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
7e5f3a5
Invoke installer for private repo support
jwpereira 6a3aaf9
Disable automatic activation
jwpereira 05bdce8
Fix failing unit test to account for addition call
jwpereira c74b56f
Add environment variables to workflow
jwpereira 9d1a304
Disable R2020a workflow; only R2020b for now
jwpereira 82c7ee1
Merge pull request #11 from matlab-actions/jpereira/pilot-enable
jwpereira 2816693
Build 82c7ee1
jwpereira ae84399
Merge branch 'main' into private-repo-pilot
jwpereira 508c6b7
Merge branch 'main' into jpereira/update-pilot
jwpereira 6a6f85e
Build for v1.0.1
jwpereira b0810e9
Remove -r from BaT workflow
jwpereira 7265f9e
Merge pull request #20 from matlab-actions/jpereira/update-pilot
jwpereira 3485584
First change
acampbel b38afb3
Use mpm
acampbel 3b78aad
Update action.yml
acampbel 3fdd0cb
Update bat.yml
acampbel 52ff614
Update install.ts
acampbel 7b15906
Add to path
acampbel d2433ee
Update index.ts
acampbel 40ff726
Pass in products
acampbel af89a2a
Add products input
acampbel 9e00645
Update bat.yml
acampbel 249748b
Cache installs
acampbel 75127fe
Update bat.yml
acampbel ac47fac
Update install.ts
acampbel e8cc1e5
Update install.ts
acampbel 3a32df3
Update install.ts
acampbel 24a56e1
Update install.ts
acampbel 09fdde4
Enable caching
acampbel e185a51
Cache in the right place
acampbel 2bd5c45
Print the key
acampbel fc813c8
More display tweaks
acampbel e324049
Get the key right
acampbel 0ef2d59
Cache
acampbel db4be46
merge changes for v2-beta (#50)
davidbuzinski 4b8f191
v2-beta bugfix (#52)
davidbuzinski 180c8e5
Update release info (#57)
davidbuzinski a01189a
Restrict supported releases (#65)
davidbuzinski 77b0040
Add cache input to leverage Github Actions cache for v2 (#73)
davidbuzinski 222b3da
Fix mpm mac windows v2-beta (#77)
davidbuzinski 7e7f2de
Updated to check if sudo command is available
sameagen-MW 4d8e316
Add tests
sameagen-MW e5233f4
Switch to registry.npmjs.org
sameagen-MW e464348
Clean up change
sameagen-MW 5826302
Update copyright
sameagen-MW 717c4e2
Update to check if which returns empty string
sameagen-MW fd8d40c
Merge pull request #78 from matlab-actions/no-sudo
sameagen-MW 1209386
merge rc0 changes to mpm branch (#83)
davidbuzinski 1a23c87
Update action node version (#84)
davidbuzinski fa9244d
resolve merge conflicts
davidbuzinski d6fadce
review comments
davidbuzinski 3ba1bee
updating README in preparation for matlab-actions/setup-matlab@v2 (#88)
mw-hrastega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
module.exports = { | ||
"env": { | ||
"browser": true, | ||
"es2021": true | ||
}, | ||
"extends": [ | ||
"eslint:recommended", | ||
"plugin:@typescript-eslint/recommended" | ||
], | ||
"overrides": [ | ||
{ | ||
"env": { | ||
"node": true | ||
}, | ||
"files": [ | ||
".eslintrc.{js,cjs}" | ||
], | ||
"parserOptions": { | ||
"sourceType": "script" | ||
} | ||
}, | ||
{ | ||
"files": [ | ||
"**/*.ts" | ||
], | ||
"rules": { | ||
"prefer-const": "off" | ||
} | ||
} | ||
], | ||
"parser": "@typescript-eslint/parser", | ||
"parserOptions": { | ||
"ecmaVersion": "latest", | ||
"sourceType": "module" | ||
}, | ||
"plugins": [ | ||
"@typescript-eslint" | ||
], | ||
"rules": { | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# Copyright 2020 The MathWorks, Inc. | ||
# Copyright 2020-2024 The MathWorks, Inc. | ||
|
||
name: Setup MATLAB | ||
description: >- | ||
|
@@ -9,6 +9,22 @@ inputs: | |
MATLAB release to set up (R2020a or later) | ||
required: false | ||
default: latest | ||
products: | ||
description: >- | ||
Array of products to install | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Array" sounds like this should be specified as a YAML array. Perhaps "Products to install, specified as a list of product names separated by spaces"? |
||
required: false | ||
default: MATLAB | ||
cache: | ||
description: >- | ||
Option to store MATLAB in the GitHub Actions cache, specified as false or true | ||
required: false | ||
default: false | ||
outputs: | ||
matlabroot: | ||
description: >- | ||
A full path to the folder where MATLAB is installed | ||
runs: | ||
using: node16 | ||
main: dist/index.js | ||
using: node20 | ||
main: dist/setup/index.js | ||
post: dist/cache-save/index.js | ||
post-if: success() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need some sort of actual noop check in the future?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that could be nice. Not immediately clear to me what that would look like