Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/cli/server, rpc: lower down http readtimeout to 10s #777

Closed
wants to merge 2 commits into from

Conversation

Raneet10
Copy link
Member

Description

Bring down default read time out to 10 sec from 30 sec

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (318b7fa) 56.70% compared to head (28f1eea) 56.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   56.70%   56.71%           
=======================================
  Files         609      609           
  Lines       70695    70713   +18     
=======================================
+ Hits        40088    40104   +16     
+ Misses      27179    27172    -7     
- Partials     3428     3437    +9     
Impacted Files Coverage Δ
rpc/http.go 72.54% <ø> (ø)
internal/cli/server/config.go 73.06% <100.00%> (ø)

... and 21 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pratikspatil024 pratikspatil024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the values in all the toml config files as well.

@pratikspatil024 pratikspatil024 requested a review from a team March 14, 2023 04:05
@Raneet10
Copy link
Member Author

Please change the values in all the toml config files as well.

Done: 28f1eea.

@Raneet10 Raneet10 mentioned this pull request Mar 14, 2023
14 tasks
@Raneet10
Copy link
Member Author

Changes included in #776 . Hence, closing this.

@Raneet10 Raneet10 closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants