Removed the check for milestoneID in the GetVoteOnHash() #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1109 +/- ##
========================================
Coverage 56.00% 56.00%
========================================
Files 658 658
Lines 114473 114460 -13
========================================
- Hits 64108 64107 -1
+ Misses 46506 46490 -16
- Partials 3859 3863 +4 ☔ View full report in Codecov by Sentry. |
Raneet10
approved these changes
Dec 19, 2023
pratikspatil024
approved these changes
Dec 19, 2023
marcello33
approved these changes
Dec 19, 2023
|
If we need to merge, please @VAIBHAVJINDAL3012 provide a bit more context and remove the |
|
I reported an issue related to this section that is causing block import delays on clients, and may also delay block production on validators. |
VAIBHAVJINDAL3012
changed the title
anshalshukla
pushed a commit
to erigontech/erigon
that referenced
this pull request
Jan 12, 2024
Removed the check for milestoneID in the GetVoteOnHash() maticnetwork/bor#1109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the check for milestoneID in the GetVoteOnHash() function, in present system there is an extra check which query the authenticity of the milestone being voted by querying the milestoneID from the Heimdall.
It seemed to be an extra check which extra call overhead and sometime also causing delay.
Changes