Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : typo in (tx *DynamicFeeTx) gasPriceU256() #1064

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix : typo in (tx *DynamicFeeTx) gasPriceU256() #1064

merged 1 commit into from
Oct 30, 2023

Conversation

0xsharma
Copy link
Contributor

Description

In this PR, we fix a typo in core/types/tx_dynamic_fee.go.

@0xsharma 0xsharma linked an issue Oct 30, 2023 that may be closed by this pull request
typo in code core/types/tx_dynamic_fee.go #1047
Closed
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
core/forkchoice.go 86.66% <100.00%> (+6.66%) ⬆️
core/types/tx_dynamic_fee.go 75.78% <0.00%> (ø)

... and 16 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@0xsharma 0xsharma merged commit ab42a16 into develop Oct 30, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raneet10 Raneet10 Raneet10 approved these changes

@manav2401 manav2401 manav2401 approved these changes

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

@anshalshukla anshalshukla anshalshukla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo in code core/types/tx_dynamic_fee.go
5 participants
@0xsharma @Raneet10 @manav2401 @pratikspatil024 @anshalshukla