feat: modify stop #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
matiasvillaverde
commented
Aug 5, 2023
matiasvillaverde
commented
- feat: Add functionality to modify stop loss orders in CLI
- feat: Update trade stop modification functionality
- Restructure trade-related validators and actions
- feat: modify stop interface
- feat: Refactor order updating methods and update trade handling logic
- feat: Modify stop order implementation to include account parameter
- fix: Refactor trade modification functionality
- feat: Add trade validation and trade action functionality
- test: Add new test case and implementation for modifying stop price in a long trade
- feat: Refactor order creation and modification functions
- Add functionality to modify the stop loss order of a filled trade - Implement a new dialog for modifying the stop price of a trade - Introduce new methods in ArgDispatcher for modifying stop prices and setting target prices for trades
- Added `BrokerLog` import to `model` in `trade_action.rs` - Modified `TradeAction` struct to include `modify_stop` method, currently unimplemented - Added `build` method to `ModifyStopDialogBuilder` in `modify_stop_dialog.rs` - Implemented `ModifyStopDialogBuilder::build` - Modified `display` method in `modify_stop_dialog.rs` to show trade stop update instead of trade submission - Modified `display` method in `modify_stop_dialog.rs` to show updated stop and remove target and entry - Added `SearchStopDialogBuilder` method in `modify_stop_dialog.rs` to search for trades with filled status - Modified `search` method in `modify_stop_dialog.rs` to display trade selection instead of account selection - Added `stop_price` method in `modify_stop_dialog.rs` to prompt for new stop price input - Added `modify_stop` method to `TrustFacade` in `lib.rs`, allowing modification of stop price for a trade
- Add a new validation function `can_modify_stop` to check if a trade can be modified - Modify several functions in `trade_action.rs` to add a check for fees and create a transaction to pay for fees - Update tests for the new validation function to cover different trade statuses
- Added new methods `update_price` and `update_submitted_at` to the `WorkerOrder` struct in `worker_order.rs` - Updated `update` and `update_filled_at` methods in `worker_order.rs` to include additional fields in the update query - Modified `modify_stop` method in `OrderWorker` struct to update stop order price and return the updated order - Updated methods in `create_stop`, `create_entry`, and `create_target` in `OrderWorker` struct to set different order categories - Modified `update_status`, `cancel_funded_trade`, and `cancel_submitted_trade` functions in `trade_action.rs` to include additional trade status handling and fund transfers - Added `update_price` method to `SqliteDatabase` implementation in `database.rs` - Added `update_price` method to `OrderWrite` trait in `database.rs`
- Added a new module `modify_trade` to `alpaca-broker/src/lib.rs` - Modified the `modify_stop` function in the `Broker` implementation - Added a `modify_stop` method to the `TrustFacade` struct - Updated `ModifyStopDialogBuilder` in `cli/src/dialogs/modify_stop_dialog.rs` to include an `account` field - Modified various methods in `cli/src/dialogs/modify_stop_dialog.rs` to include calls to `modify_stop` with the `account` parameter - Made changes to `cli/src/dialogs/modify_stop_dialog.rs` to display updated trade stop and order, and prompt for a new stop price - Imported `Decimal` and changed the return type of `modify_stop` function in `cli/tests/integration_test_account.rs` - Modified the `modify_stop` function signature in `model/src/broker.rs` to remove `(Order, BrokerLog)` return type and added `account` parameter - Added a new file `modify_trade.rs` in `alpaca-broker/src` directory - Implemented the `modify_stop` function in `alpaca-broker/src/modify_trade.rs` to modify a stop order for a trade - Made changes in `cli/tests/integration_test_trade.rs` to import `Decimal`, modify various methods, implement `cancel_trade` and `modify_stop` methods, and log modifications in `modify_stop` method - Made changes in `core/src/workers/trade_action.rs` including conditionals for different status updates, creating transactions for fund transfers, creating target order, and modifying the stop order
- Fixed a typo in the function name `modify_stop` to `modify_entry` - Changed the field `limit_price` to `stop_price` in the `ChangeReqInit` struct
- Added `TradeCategory` and `Decimal` imports to `validators/trade.rs` - Added parameter `new_price_stop` and validation for modifying stop price in `can_modify_stop` function in `validators/trade.rs` - Added error code `TradeValidationErrorCode::StopPriceNotValid` and `TradeValidationError` struct in `validators/trade.rs` - Added tests for trade validation functions in `validators/trade.rs` - Added `TradeAction` struct, `update_status`, `fill_trade`, `target_executed`, `stop_executed`, `create_trade`, `stop_trade`, `target_acquired`, `cancel_funded_trade`, `cancel_submitted_trade`, and `modify_stop` functions to `trade_action.rs` in `workers` directory.
…n a long trade - Added integration test for modifying stop price in a long trade - Implemented `modify_stop` function in `MockBroker` struct - Asserted correct trade, account, and new stop price values when calling `modify_stop` function - Updated stop price to 39 and reflected change in `safety_stop.unit_price` field of trade
- Refactored core/src/workers/order_worker.rs to use new functions and update order categories - Fixed a typo in cli/src/dialogs/modify_stop_dialog.rs - Removed unused variable and unnecessary cloning in cli/src/dialogs/modify_stop_dialog.rs - Improved error message and removed unnecessary cloning in cli/src/dialogs/modify_stop_dialog.rs - Removed unnecessary context and comments in cli/src/dialogs/modify_stop_dialog.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.