pthread wasn't being linked, I added it to CMakeLists.txt #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasinsaurralde
added a commit
that referenced
this pull request
Mar 19, 2015
pthread wasn't being linked, I added it to CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple, I was trying to build on Debian and was getting this
/usr/bin/ld: libtun.a(tun.cpp.o): undefined reference to symbol 'pthread_create@@GLIBC_2.2.5'
//lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
CMakeFiles/facebook-tunnel.dir/build.make:94: recipe for target 'facebook-tunnel' failed
make[2]: *** [facebook-tunnel] Error 1
CMakeFiles/Makefile2:170: recipe for target 'CMakeFiles/facebook-tunnel.dir/all' failed
make[1]: *** [CMakeFiles/facebook-tunnel.dir/all] Error 2
Makefile:76: recipe for target 'all' failed
make: *** [all] Error 2
Which just meant that pthread wasn't being linked correctly on Debian 8. Given the ubiquity of Debian-based systems I added it to CMakeLists.txt. Look forward to getting this to compile on the Android NDK.