Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added options to command face:sync-albums #709

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

wronny
Copy link
Contributor

@wronny wronny commented Nov 16, 2023

Hello,
I like facerecognition and its sync-album command. Because I don't want/need to create albums for all persons I added an option to create only albums for selected persons. I also like to create albums with photos containing several persons therefore I added a mode option "Album-per-person" vs "Album-combined". Also added a list persons option to allow to list persons from command line.

Options added to command face:sync-albums:
-l, --list_persons : List all person defined for a given user_id
-p, --person_name=PERSON_NAME : Sync albums for a given user and person name(s) (separeted using comma). If not used, sync all persons defined by the user
-m, --mode=MODE : Album creation mode. Use "Album-per-person" to create one album for each given person via person_name parameter. Use "Album-combined" to create one album for all person names given via person_name parameter. [default: "Album-per-user"]

I hope this is meaningful/helpful also for others. Of course open for feedback / discussion.

Cheers,
Marcel

    -l, --list_persons : List all person defined for a given user_id
    -p, --person_name=PERSON_NAME : Sync albums for a given user and person name(s) (separeted using comma). If not used, sync all persons defined by the user
    -m, --mode=MODE : Album creation mode. Use "Album-per-person" to create one album for each given person via person_name parameter. Use "Album-combined" to create one album for all person names given via person_name parameter. [default: "Album-per-user"]

Signed-off-by: wronny <github@wron.de>
@matiasdelellis
Copy link
Owner

Hi @wronny
Thank you very much for the contribution. I find it very interesting. 😬

I haven't been able to try it yet, because I'm dealing with other issues, but I'll try to do it these days.. 😄

@matiasdelellis
Copy link
Owner

Well,
I was never able to test it properly, but it's a nice addition, and doesn't change the previous flow.

Thanks again,

@matiasdelellis matiasdelellis merged commit af3dd7f into matiasdelellis:master Apr 23, 2024
@matiasdelellis
Copy link
Owner

Wow!. I'm just trying it and I love it!! 😄

Misc fixes on last commit... mainly caps and spaces, and now it works without any arguments (which seems to have never worked! 🤦🏻).

@wronny wronny deleted the sync-album-added-options branch April 25, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants