Merged
Conversation
Collaborator
gabrielbornstein
left a comment
gabrielbornstein
left a comment
There was a problem hiding this comment.
Part 1 of my review, just going over the kv_store files. I'll look at the mem_table files next.
Collaborator
gabrielbornstein
left a comment
gabrielbornstein
left a comment
There was a problem hiding this comment.
Second round, I'll finish out my review of mem_table.cpp tomorrow
vidyasilai
reviewed
Feb 19, 2026
Collaborator
vidyasilai
left a comment
vidyasilai
left a comment
There was a problem hiding this comment.
Everything looks great to me! Just a few small questions/comments.
vidyasilai
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And some additional metrics collection in ResultSet.